#8 Empty event in modules.txt break the module

Closed
opened 5 years ago by LecygneNoir · 2 comments
Owner

There are sometimes empty events inside modules, like in Cave.txt:

-- [EVENT] --CaveDiff1(13)
[/EVENT]

As there is no text to translate, this event disappear when importing to Zanata...

And when rollbacking, number of event are incorrect (index 14 for only 13 events) so the rollback is incorrect and it breaks the module.

It generates too much [/EVENT] at the end of the file, which prevents importing the module into Thea2 (and even crashes the game)

End of rollbacked Cave.txt:

[/NODE]

[/EVENT]


[/NODE]

[/EVENT]

I need to find a workaround for that. Generating the module without the event could do the job (need to test inside Thea2), but if this does not work, it will be very hard to guess missing event because they are missing...

There are sometimes empty events inside modules, like in Cave.txt: ``` -- [EVENT] --CaveDiff1(13) [/EVENT] ``` As there is no text to translate, this event disappear when importing to Zanata... And when rollbacking, number of event are incorrect (index 14 for only 13 events) so the rollback is incorrect and it breaks the module. It generates too much [/EVENT] at the end of the file, which prevents importing the module into Thea2 (and even crashes the game) End of rollbacked Cave.txt: ``` [/NODE] [/EVENT] [/NODE] [/EVENT] ``` I need to find a workaround for that. Generating the module without the event could do the job (need to test inside Thea2), but if this does not work, it will be very hard to guess missing event because they are missing...
Poster
Owner

Ok after tests in game, it's OK if the event 13 is missing, there is no text so the module editor does not complains, and as it's empty the module is not activated in game yet, so everything works

Ok after tests in game, it's OK if the event 13 is missing, there is no text so the module editor does not complains, and as it's empty the module is not activated in game yet, so everything works
LecygneNoir referenced this issue from a commit 5 years ago
Poster
Owner

Tests are okay for this bug after the last fix, could be closed

Tests are okay for this bug after the last fix, could be closed
LecygneNoir closed this issue 5 years ago
Sign in to join this conversation.
No Label
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.