Some modules are broken after compilation from po to txt

I have noticed than some modules does not load in the game after compilation.

From what I have identified at the moment, this is because a problem in compilation, creating some odd lines like:

[OUT]Attaquer !#. -- [EVENT] --WoodKilladvSkel(10)@@+[NODE]2@@[OUT]10#. -- [EVENT] --WoodlandKinTradesmall(11)@@+[NODE]2@@[OUT]4#. -- [EVENT] --WoodlandKinTradesmall(11)@@+[NODE]7@@[OUT]2#. -- [EVENT] --WoodlandKinTrademedium(12)@@+[NODE]2@@[OUT]4#. -- [EVENT] --WoodlandKinTrademedium(12)@@+[NODE]7@@[OUT]2#. -- [EVENT] --WoodlandKinTradeadv(13)@@+[NODE]2@@[OUT]4#. -- [EVENT] --WoodlandKinTradeadv(13)@@+[NODE]7@@[OUT]2msgid "Come back another time.Revenir plus tard.Revenir plus tard.

Here a cut was incorrect and insert a full source-common line in a OUT event.

My best guess is something incorrect in the rollback process, perhaps because of array sorting.

Need to dig!

Okay it was a mistake inside the regex when looking for a event

eg if the event is

#. -- [EVENT] --WoodKilladvSkel(10)@@+[NODE]2@@[OUT]1

#. -- [EVENT] --WoodKilladvSkel(10)@@+[NODE]2@@[OUT]10

it matches (1 versus 10), so the treatment after keep the full string :-/

I have added the old one $ to specify the end of line in the regex, and everything is back to normal 🙏

LecygneNoir referenced this issue from a commit 5 years ago

Add a $ at the end of the regex to rollback module to avoid breaking syntax. Definitely fix #4

LecygneNoir closed this issue 5 years ago

#4 Some modules are broken after compilation from po to txt