LecygneNoir
/
thea2Shattering_i18n_tools
1
0
Bifurcation 0
Code Tickets 0 Demandes d'ajout 0 Versions 9 Wiki Activité
Étiquettes Jalons
Nouveau ticket

#10 Empty event in module break the rollback from po

Fermé
créé il y a 4 ans par LecygneNoir · 3 commentaires
LecygneNoir a commenté il y a 4 ans
Propriétaire

It appears there are empty event in some modules:

-- [EVENT] --DemonEncounterBase(0)
[/EVENT]

As they are empty, these events are not added in the po and just ignored.

But, when we reconstruct the txt from the pot file, we do not know about these event, so they are missing, and it break the game.

Indeed, the game ignore the (X) balise which is the number of the event, and instead use them sequentially.
In the exemple above, as the (0) event is missing, everything are in the wrong order... translation for (1) event is considered as (0), (2) event is considered as (1), etc

Thus, all quests and choices are wrong and has no sense :-/

I join a screenshot to illustrate.

We need to find a way to remember empty events when rollbacking pot to txt, in order to have all info.

I see two possibilities:

  1. Using the original txt when rollbacking as a base to know about empty events
  2. Storing information about empty event in the .po to have it when rollbacking
It appears there are empty event in some modules: ``` -- [EVENT] --DemonEncounterBase(0) [/EVENT] ``` As they are empty, these events are not added in the po and just ignored. But, when we reconstruct the txt from the pot file, we do not know about these event, so they are missing, and it break the game. Indeed, the game ignore the `(X)` balise which is the number of the event, and instead use them sequentially. In the exemple above, as the (0) event is missing, everything are in the wrong order... translation for (1) event is considered as (0), (2) event is considered as (1), etc Thus, all quests and choices are wrong and has no sense :-/ I join a screenshot to illustrate. We need to find a way to remember empty events when rollbacking pot to txt, in order to have all info. I see two possibilities: 1. Using the original txt when rollbacking as a base to know about empty events 2. Storing information about empty event in the .po to have it when rollbacking
606230_screenshots_20191016173106_1.jpg
365 KiB
LecygneNoir a commenté il y a 4 ans
Publier
Propriétaire

I already used base module xml for the DATABASE files, but for event it's pretty harder, the rollback algorithm I have to write is absolutely not adapted to that, performance should be very poor :-/

So I choose the solution 2.

It force to add translation that are not really translation in Zanata, but I think it's not too disturbing, regarding the time gained for rollback

I already used base module xml for the DATABASE files, but for event it's pretty harder, the rollback algorithm I have to write is absolutely not adapted to that, performance should be very poor :-/ So I choose the solution 2. It force to add translation that are not really translation in Zanata, but I think it's not too disturbing, regarding the time gained for rollback
LecygneNoir a commenté il y a 4 ans
Publier
Propriétaire

For example, in the pot:

#. #-#-#-#-#  Bandits attack.pot  #-#-#-#-#
#. -- [EVENT] --BanditsAttackDiff7(13)EMPTY@@[EMPTY]0@@[EMPTY]0
msgid "[SPECIAL EMPTY EVENT STRING]"
msgstr "[SPECIAL EMPTY EVENT STRING]"
For example, in the pot: ``` #. #-#-#-#-# Bandits attack.pot #-#-#-#-# #. -- [EVENT] --BanditsAttackDiff7(13)EMPTY@@[EMPTY]0@@[EMPTY]0 msgid "[SPECIAL EMPTY EVENT STRING]" msgstr "[SPECIAL EMPTY EVENT STRING]" ```
LecygneNoir a commenté il y a 4 ans
Publier
Propriétaire

With little adaptation, the scripts used to work on event now managed empty event correctly 👍

With little adaptation, the scripts used to work on event now managed empty event correctly :+1:
LecygneNoir a fermé ce ticket il y a 4 ans
Connectez-vous pour rejoindre cette conversation.
Aucune branche/tag spécifiés
Branches Tags
Étiquettes
Appliquer une étiquette
Effacer les étiquettes
Pas d'élément
Pas d'étiquette
Jalon
Affecter un jalon
Effacer le jalon
Pas d'élément
Aucun jalon
Affecté à
Assigner des utilisateurs
Supprimer les affectations
Pas d'assignataires
1 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

Ce ticket n'a actuellement pas de dépendance.

Écrire Aperçu
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.
Supprimer la branche '%!s(MISSING)'

Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?

Non
Oui