LecygneNoir
/
prismedia
1
1
Fork 4
Code Issues 15 Pull Requests 0 Releases 22 Wiki Activity
Labels Milestones
New Pull Request

#54 hearthbeat (keepalive ?)

Merged
LecygneNoir merged 4 commits from Zykino/prismedia:hearthbeat into develop 3 years ago
Conversation 1 Commits 4 Files Changed 4
Zykino commented 3 years ago

Use a bit of Youtube’s quota to tell them not to invalidate the apikey.

Use a bit of Youtube’s quota to tell them not to invalidate the apikey.
Zykino added 2 commits 3 years ago
a725e848ab Add an option to use some credits easiely
Zykino force-pushed hearthbeat from 7a691a1fae to 29b1747c3e 3 years ago
Zykino changed title from WIP: hearthbeat to hearthbeat (keepalive ?) 3 years ago
LecygneNoir commented 3 years ago
Poster
Owner

The idea is interesting, indeed if you get caught by google for no use and they reduce your quota to 0, regaining some quota is a real PITA, this may avoid this 👌

The idea is interesting, indeed if you get caught by google for no use and they reduce your quota to 0, regaining some quota is a real PITA, this may avoid this 👌
LecygneNoir requested changes 3 years ago
prismedia/upload.py
Usage:
prismedia --file=<FILE> [options]
prismedia -f <FILE> --tags=STRING [options]
prismedia --hearthbeat
LecygneNoir commented 3 years ago

--file is mandatory, shouldn't we set it optional to allow launching prismedia with --hearbeat only?

So --file becomes optionnal, perhaps exclusive with --heartbeat. With a check so if there is not --file nor --hertbeat present, we disply the help? (One of two is mandatory)

`--file` is mandatory, shouldn't we set it optional to allow launching prismedia with `--hearbeat` only? So `--file` becomes optionnal, perhaps exclusive with `--heartbeat`. With a check so if there is not `--file` nor `--hertbeat` present, we disply the help? (One of two is mandatory)
Zykino commented 3 years ago

Yes one of the two is mandatory and both are exclusives (at least in my mind).

I had to add this usage otherwise I had an error. But I added quickly, there may be a better syntax to highlight what we are both thinking.

Yes one of the two is mandatory and both are exclusives (at least in my mind). I had to add this usage otherwise I had an error. But I added quickly, there may be a better syntax to highlight what we are both thinking.
LecygneNoir marked this conversation as resolved
prismedia/upload.py
Only relevant if --playlist is set.
--progress=STRING Set the progress bar view, one of percentage, bigFile (MB), accurate (KB).
--hearthbeat Use some credits to show some activity for you apikey so the platform know it is used and would not put your quota to 0 (only Youtube currently)
LecygneNoir commented 3 years ago

I think we may add a section for heartbeat in README as documentation, to explain the way to use it.

Do you plan to use cron? Or some daemon? Perhaps a beehive example? ;-)

Thanks!

I think we may add a section for heartbeat in README as documentation, to explain the way to use it. Do you plan to use cron? Or some daemon? Perhaps a beehive example? ;-) Thanks!
Zykino commented 3 years ago

Yeah I forgot to add the readme and explain "just use cron on Linux or add it in the Windows sheduler to be triggered once a month". Not sure if more details are needed.

Yeah I forgot to add the readme and explain "just use cron on Linux or add it in the Windows sheduler to be triggered once a month". Not sure if more details are needed.
Zykino marked this conversation as resolved
LecygneNoir reviewed 3 years ago
prismedia/yt_upload.py
if playlist["snippet"]['title'] == playlist_name:
return playlist['id']
pageToken = ""
while pageToken != None:
LecygneNoir commented 3 years ago

Oh you find a way for youtube pagination, great! 👏 💪

Oh you find a way for youtube pagination, great! 👏 💪
Zykino marked this conversation as resolved
LecygneNoir reviewed 3 years ago
prismedia/yt_upload.py
LecygneNoir commented 3 years ago

Little typo: no space before the : in english :-)
(BTW, I'll probably use the release for this MR to track the last spaces that remains in code 😂 )

Little typo: no space before the : in english :-) (BTW, I'll probably use the release for this MR to track the last spaces that remains in code :joy: )
Zykino commented 3 years ago

I think I fixed everything. But if there are more/other things, feel free to fix the rest :)

I think I fixed everything. But if there are more/other things, feel free to fix the rest :)
LecygneNoir marked this conversation as resolved
Zykino added 1 commit 3 years ago
LecygneNoir merged commit ca733e0dc3 into develop 3 years ago
Zykino deleted branch hearthbeat 3 years ago

Reviewers

LecygneNoir requested changes 3 years ago
The pull request has been merged as ca733e0dc3.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 LecygneNoir
Labels
Apply labels
Clear labels
bug duplicate enhancement help wanted invalid More info needed question To reproduce
need to reproduce in order to fix Todo wontfix Work in Progress
someone is currently working on it
No Label
bug
duplicate
enhancement
help wanted
invalid
More info needed
question
To reproduce
Todo
wontfix
Work in Progress
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Zykino/prismedia:hearthbeat'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes