Decode strings received from the cli arguments, fix #12

New Pull Request

Conversation 2 Commits 7 Files Changed 3

Fixes #12

Now that I think about it we may indicate that Prismedia consider the .nfo file to be UTF-8 encoded. (I did not test with other encoding but I suspect the same kind of bug.)

Zykino changed title from ~~Decode strings received from the cli arguments~~ to [WIP] Decode strings received from the cli arguments 5 years ago

Zykino changed title from ~~[WIP] Decode strings received from the cli arguments~~ to Decode strings received from the cli arguments 5 years ago

Zykino changed title from ~~Decode strings received from the cli arguments~~ to Decode strings received from the cli arguments, fix #12 5 years ago

Tested on your test instance: accents from command line interface are uploaded correctly. Accents from an UTF-8 encoded file works great too.

I did not test other file encoding for the NFO. But even if I test it, it should not be Windows specific. And I did not find a way to detect the encoding of a file in Python. (Other than call a lib which will brute force the detection.)

If it's still works on linux I think you can merge it.

LecygneNoir reviewed 5 years ago

lib/utils.py Outdated

LecygneNoir commented 5 years ago

Little typo here, decoding :)

I fixed the typo and rebased (to erase the conflit)

LecygneNoir closed this pull request 5 years ago

Zykino deleted branch feature/encoding 5 years ago

The pull request has been merged as 5907859066.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#21 Decode strings received from the cli arguments, fix #12