#60 Prismedia should have option to disable file format check

Closed
opened 2 months ago by Sierran · 4 comments
Sierran commented 2 months ago

Hello! At the start, I would like to thank you for providing a great tool! :) Currently I have over 500 m4a files that I would like to upload to my instance.. But I can't because prismedia checks the file type and every time I want to massively upload I have to approve that I want to upload this type of file (.m4a). I would like to see some flag that would disable checking the file type. Then I could write a script that will upload for me over 500 files :)

Hello! At the start, I would like to thank you for providing a great tool! :) Currently I have over 500 m4a files that I would like to upload to my instance.. But I can't because prismedia checks the file type and every time I want to massively upload I have to approve that I want to upload this type of file (.m4a). I would like to see some flag that would disable checking the file type. Then I could write a script that will upload for me over 500 files :)
Sierran changed title from Prismedia should have option to disable file format check. to Prismedia should have option to disable file format check 2 months ago
LecygneNoir added the
enhancement
label 2 months ago
LecygneNoir added the
Todo
label 2 months ago
Poster
Owner

Hello!

Thank you for your interest!

It's a good catch indeed. This check is inherited from the beginnings of Peertube, where it supported only mp4.

Now that peertube supports at least (if not more) format than Youtube, I think the check is even useless. Perhaps a simple check to see if it's a video no matter the format could be sufficient.

I'll work on it thr the next release!

In the meantime, if you use prismedia from the repository (not from pip), you may script your upload by manually editing line 158

Replace supported_types = ['video/mp4'] by return path and the warning should disapear.

Hope it helps!

I'll update the ticket once the release is ready :-)

Regards,

Hello! Thank you for your interest! It's a good catch indeed. This check is inherited from the beginnings of Peertube, where it supported only mp4. Now that peertube supports at least (if not more) format than Youtube, I think the check is even useless. Perhaps a simple check to see if it's a video no matter the format could be sufficient. I'll work on it thr the next release! In the meantime, if you use prismedia from the repository (not from pip), you may script your upload by manually editing [line 158](https://git.lecygnenoir.info/LecygneNoir/prismedia/src/branch/master/prismedia/upload.py#L158) Replace `supported_types = ['video/mp4']` by `return path` and the warning should disapear. Hope it helps! I'll update the ticket once the release is ready :-) Regards,
Sierran commented 2 months ago
Poster

Thank you for your quick reply!

I look forward to the change and right now you are right, I can modify the code from git :)

Taking this opportunity, I have a question. Why own gitea instance and not github? I must admit that I found this project by accident, searching things on pypi. Earlier I had not found any mention of it on the internet and I started writing my own tool :<

Thank you for your quick reply! I look forward to the change and right now you are right, I can modify the code from git :) Taking this opportunity, I have a question. Why own gitea instance and not github? I must admit that I found this project by accident, searching things on pypi. Earlier I had not found any mention of it on the internet and I started writing my own tool :<
Poster
Owner

About not hosting on github, it mainly a matter of habits. I self host everything I work on, so do not using github is obvious for me 😅

This gitea is referenced on search engine, so I guess with good keywords it should be found. I am not sure that if the project was on github it would be easier to find.

Perhaps the key point I may work on is to have a better description for the project so bots have better reference 🤔

Anyway thanks for the report, it's interresting to know!

About not hosting on github, it mainly a matter of habits. I self host everything I work on, so do not using github is obvious for me 😅 This gitea is referenced on search engine, so I guess with good keywords it should be found. I am not sure that if the project was on github it would be easier to find. Perhaps the key point I may work on is to have a better description for the project so bots have better reference 🤔 Anyway thanks for the report, it's interresting to know!
LecygneNoir added the
Work in Progress
label 2 months ago
Poster
Owner

Fixed by #62, shoud lbe release in v0.12.0!

Fixed by #62, shoud lbe release in v0.12.0!
LecygneNoir removed the
Todo
label 2 months ago
LecygneNoir removed the
Work in Progress
label 2 months ago
LecygneNoir closed this issue 2 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.