#41 Playlists are recreated when they already exist

已關閉
LecygneNoir4 年之前建立 · 4 條評論
所有者

I have found a bug in Peertube directly, where if you have more than 14 playslists, the API return only the 14 more recently modified.

So prismedia think the playlist does not exist and recreate it.

A bug is currently open on Peertube bug report : https://github.com/Chocobozzz/PeerTube/issues/2138

Will wait for news about it, and update prismedia if needed once I have more info

I have found a bug in Peertube directly, where if you have more than 14 playslists, the API return only the 14 more recently modified. So prismedia think the playlist does not exist and recreate it. A bug is currently open on Peertube bug report : https://github.com/Chocobozzz/PeerTube/issues/2138 Will wait for news about it, and update prismedia if needed once I have more info
LecygneNoir added the
bug
label 4 年之前
LecygneNoir added the
More info needed
label 4 年之前
LecygneNoir changed title from Playlists are recreated when they arleady exist to Playlists are recreated when they already exist 4 年之前
發佈者
所有者

After tests, this is a Peertube bug, see to bug report in the first post about that.

A workaround exist, but need to edit manually the server component of Peertube.

For the moment, no solution, but we may have to modify prismedia once the Peertube bug is solved, perhaps to add some option to the API.

After tests, this is a Peertube bug, see to bug report in the first post about that. A workaround exist, but need to edit manually the server component of Peertube. For the moment, no solution, but we may have to modify prismedia once the Peertube bug is solved, perhaps to add some option to the API.
LecygneNoir removed the
More info needed
label 4 年之前
LecygneNoir added the
wontfix
label 4 年之前
LecygneNoir closed this issue 4 年之前
發佈者
所有者

According to the last answer of the Peertube bug by Rigelk: https://github.com/Chocobozzz/PeerTube/issues/2138#issuecomment-569037287

There is now a search function in the API that we could use instead of retrieving the list as we currently do. (retrieving the list still returns 14 last playlists)

I reopen to take time to work on it!

According to the last answer of the Peertube bug by Rigelk: https://github.com/Chocobozzz/PeerTube/issues/2138#issuecomment-569037287 There is now a search function in the API that we could use instead of retrieving the list as we currently do. (retrieving the list still returns 14 last playlists) I reopen to take time to work on it!
LecygneNoir reopened this issue 3 年之前
LecygneNoir removed the
wontfix
label 3 年之前
LecygneNoir added the
Todo
label 3 年之前
發佈者
所有者

As notified by @Zykino, the function we currently use accept parameters to iterage on pagination, eg adding count=1&start=16

As it also returns the total number of playlist, we may use it to find the correct playlist if needed, but be careful as it may have lot of playlist :-/

As notified by @Zykino, the function we currently use accept parameters to iterage on pagination, eg adding count=1&start=16 As it also returns the total number of playlist, we may use it to find the correct playlist if needed, but be careful as it may have lot of playlist :-/
LecygneNoir removed the
Todo
label 3 年之前
LecygneNoir added the
Work in Progress
label 3 年之前
發佈者
所有者

According to the documentation the max count allowed by peertube is 100

If you try more than 100 (eg: 101), it returns an error:

{'errors': {'count': {'value': '101', 'msg': 'Should have a number count (max: 100)', 'param': 'count', 'location': 'query'}}}
2020-11-11 09:57:03,671 - Prismedia - ERROR: Peertube: 'data'

But, if we have less than 100 and pass count=100, it works.

So we may mitigate the bug by requesting 100 directly. Problem will occurs when a user have more than 100 playlists ^^"

For this case, we have to rewrite the get_playlist function to use pagination, according to the total of playlists returned by the API.

According to [the documentation](https://docs.joinpeertube.org/api-rest-reference.html#tag/Video-Playlists/paths/~1video-playlists~1privacies/get) the max `count` allowed by peertube is 100 If you try more than 100 (eg: 101), it returns an error: ``` {'errors': {'count': {'value': '101', 'msg': 'Should have a number count (max: 100)', 'param': 'count', 'location': 'query'}}} 2020-11-11 09:57:03,671 - Prismedia - ERROR: Peertube: 'data' ``` But, if we have less than 100 and pass `count=100`, it works. So we may mitigate the bug by requesting 100 directly. Problem will occurs when a user have more than 100 playlists ^^" For this case, we have to rewrite the get_playlist function to use pagination, according to the total of playlists returned by the API.
LecygneNoir 在代碼提交 3 年之前 中引用了該問題
LecygneNoir closed this issue 3 年之前
登入 才能加入這對話。
未選擇里程碑
No Assignees
1 參與者
訊息
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
尚未有任何內容