#41 Playlists are recreated when they already exist

Zamknięty
otworzone 4 lat temu przez LecygneNoir · 4 komentarzy
LecygneNoir skomentował(-a) 4 lat temu
Właściciel

I have found a bug in Peertube directly, where if you have more than 14 playslists, the API return only the 14 more recently modified.

So prismedia think the playlist does not exist and recreate it.

A bug is currently open on Peertube bug report : https://github.com/Chocobozzz/PeerTube/issues/2138

Will wait for news about it, and update prismedia if needed once I have more info

I have found a bug in Peertube directly, where if you have more than 14 playslists, the API return only the 14 more recently modified. So prismedia think the playlist does not exist and recreate it. A bug is currently open on Peertube bug report : https://github.com/Chocobozzz/PeerTube/issues/2138 Will wait for news about it, and update prismedia if needed once I have more info
LecygneNoir dodał(-ęła) etykietę
bug
4 lat temu
LecygneNoir dodał(-ęła) etykietę
More info needed
4 lat temu
LecygneNoir zmieniono tytuł z Playlists are recreated when they arleady exist na Playlists are recreated when they already exist 4 lat temu
LecygneNoir skomentował(-a) 4 lat temu
Autor
Właściciel

After tests, this is a Peertube bug, see to bug report in the first post about that.

A workaround exist, but need to edit manually the server component of Peertube.

For the moment, no solution, but we may have to modify prismedia once the Peertube bug is solved, perhaps to add some option to the API.

After tests, this is a Peertube bug, see to bug report in the first post about that. A workaround exist, but need to edit manually the server component of Peertube. For the moment, no solution, but we may have to modify prismedia once the Peertube bug is solved, perhaps to add some option to the API.
LecygneNoir usunął(-ęła) etykietę
More info needed
4 lat temu
LecygneNoir dodał(-ęła) etykietę
wontfix
4 lat temu
LecygneNoir zamknął(-ęła) to zgłoszenie 4 lat temu
LecygneNoir skomentował(-a) 3 lat temu
Autor
Właściciel

According to the last answer of the Peertube bug by Rigelk: https://github.com/Chocobozzz/PeerTube/issues/2138#issuecomment-569037287

There is now a search function in the API that we could use instead of retrieving the list as we currently do. (retrieving the list still returns 14 last playlists)

I reopen to take time to work on it!

According to the last answer of the Peertube bug by Rigelk: https://github.com/Chocobozzz/PeerTube/issues/2138#issuecomment-569037287 There is now a search function in the API that we could use instead of retrieving the list as we currently do. (retrieving the list still returns 14 last playlists) I reopen to take time to work on it!
LecygneNoir otworzył(-a) ponownie to zgłoszenie 3 lat temu
LecygneNoir usunął(-ęła) etykietę
wontfix
3 lat temu
LecygneNoir dodał(-ęła) etykietę
Todo
3 lat temu
LecygneNoir skomentował(-a) 3 lat temu
Autor
Właściciel

As notified by @Zykino, the function we currently use accept parameters to iterage on pagination, eg adding count=1&start=16

As it also returns the total number of playlist, we may use it to find the correct playlist if needed, but be careful as it may have lot of playlist :-/

As notified by @Zykino, the function we currently use accept parameters to iterage on pagination, eg adding count=1&start=16 As it also returns the total number of playlist, we may use it to find the correct playlist if needed, but be careful as it may have lot of playlist :-/
LecygneNoir usunął(-ęła) etykietę
Todo
3 lat temu
LecygneNoir dodał(-ęła) etykietę
Work in Progress
3 lat temu
LecygneNoir skomentował(-a) 3 lat temu
Autor
Właściciel

According to the documentation the max count allowed by peertube is 100

If you try more than 100 (eg: 101), it returns an error:

{'errors': {'count': {'value': '101', 'msg': 'Should have a number count (max: 100)', 'param': 'count', 'location': 'query'}}}
2020-11-11 09:57:03,671 - Prismedia - ERROR: Peertube: 'data'

But, if we have less than 100 and pass count=100, it works.

So we may mitigate the bug by requesting 100 directly. Problem will occurs when a user have more than 100 playlists ^^"

For this case, we have to rewrite the get_playlist function to use pagination, according to the total of playlists returned by the API.

According to [the documentation](https://docs.joinpeertube.org/api-rest-reference.html#tag/Video-Playlists/paths/~1video-playlists~1privacies/get) the max `count` allowed by peertube is 100 If you try more than 100 (eg: 101), it returns an error: ``` {'errors': {'count': {'value': '101', 'msg': 'Should have a number count (max: 100)', 'param': 'count', 'location': 'query'}}} 2020-11-11 09:57:03,671 - Prismedia - ERROR: Peertube: 'data' ``` But, if we have less than 100 and pass `count=100`, it works. So we may mitigate the bug by requesting 100 directly. Problem will occurs when a user have more than 100 playlists ^^" For this case, we have to rewrite the get_playlist function to use pagination, according to the total of playlists returned by the API.
LecygneNoir wspomniał(-a) to zgłoszenie z commita 3 lat temu
LecygneNoir zamknął(-ęła) to zgłoszenie 3 lat temu
Zaloguj się, aby dołączyć do tej rozmowy.
Brak kamienia milowego
Brak przypisanych
Uczestnicy 1
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

To zgłoszenie nie ma w tej chwili żadnych zależności.

Ładowanie…
Nie ma jeszcze treści.