#36 Prevent upload when the thumbnail is missing

クローズ
Zykino4年前に作成 · 7件のコメント
Zykino4年前 にコメント

I'm thinking about an option like --strict which may be reusable for other components.

I want this option because my thumbnails are not very different from one to the other, just the episode number is changing. So I do a bunch of thumbnails in advance and if I'm not careful, I may upload a video without it.

I'm thinking about an option like `--strict` which may be reusable for other components. I want this option because my thumbnails are not very different from one to the other, just the episode number is changing. So I do a bunch of thumbnails in advance and if I'm not careful, I may upload a video without it.
LecygneNoir4年前 にコメント
投稿者
オーナー

Mmmh, you mean if you specify the --strict option, then it does not upload if thumbnail is missing?

But how can you specify which option are strict for you? I mean, perhaps for another it would be a schedule that is mandatory, or tags, ...

Perhaps an option inside the NFO to specify strict parameters?

Mmmh, you mean if you specify the `--strict` option, then it does not upload if thumbnail is missing? But how can you specify which option are strict for you? I mean, perhaps for another it would be a schedule that is mandatory, or tags, ... Perhaps an option inside the NFO to specify strict parameters?
LecygneNoir がラベル
More info needed
を追加 4年前
LecygneNoir がラベル
enhancement
を追加 4年前
Zykino4年前 にコメント
投稿者

I thought we choose and hardcode this behavior for pre-selected part. Or the option require that everything is set. But a list in the NFO is the more reasonable when looking this way.

In fact I thought only about thumbnails because they are "external" to the cli: I'm copy pasting the same cmd each time and then I know I need to change 1) the file name 2) the date and 3) the title. The 2 first are triggering errors if I don't change them. (I presetted the date in the past, the name replace the episode number with a "X").

I go to the prismedia's folder, copy the saved cmd from my editor (or your shell history), adapt the cmd. Copy past the saved/memo title.
Then I press [Enter].

I never go in the video's folder where the episodes and thumbnails are (with a similar name so Prismedia find them automatically).

I thought we choose and hardcode this behavior for pre-selected part. Or the option require that everything is set. But a list in the NFO is the more reasonable when looking this way. In fact I thought only about thumbnails because they are "external" to the cli: I'm copy pasting the same cmd each time and then I know I need to change 1) the file name 2) the date and 3) the title. The 2 first are triggering errors if I don't change them. (I presetted the date in the past, the name replace the episode number with a "X"). I go to the prismedia's folder, copy the saved cmd from my editor (or your shell history), adapt the cmd. Copy past the saved/memo title. Then I press `[Enter]`. I never go in the video's folder where the episodes and thumbnails are (with a similar name so Prismedia find them automatically).
LecygneNoir がラベル
More info needed
を除去 4年前
LecygneNoir がラベル
Todo
を追加 4年前
LecygneNoir4年前 にコメント
投稿者
オーナー

Hello,

Regarding your particular problem with thumbnail, do you know that if you name your thumbnail with the same name of your video, prismedia will take it automatically?

For example if your directory contains:

Videoblabla Name.jpg
Videoblabla Name.mp4
Videoblabla Name.txt

Then you only need to passe the .mp4 to prismedia, and it'll use the NFO and the thumbnail automatically!

Eg:

./prismedia_upload.py --file="Videoblabla Name.mp4"

Let me know if it solves your problem :-)

Hello, Regarding your particular problem with thumbnail, do you know that if you name your thumbnail with the same name of your video, prismedia will take it automatically? For example if your directory contains: ``` Videoblabla Name.jpg Videoblabla Name.mp4 Videoblabla Name.txt ``` Then you only need to passe the .mp4 to prismedia, and it'll use the NFO and the thumbnail automatically! Eg: ``` ./prismedia_upload.py --file="Videoblabla Name.mp4" ``` Let me know if it solves your problem :-)
Zykino4年前 にコメント
投稿者

I didn't know for the .txt but was aware for the .jpg.

The problem is that arriving at episode #50 I just don't remember if I already created the thumbnail or not.

When uploading on the web interface I see if the thumbnail is ready or not. On CLI I do not have any indication. Especially since ./prismedia_upload.py --file="Videoblabla Name.mp4" enable me to add the thumbnail without thinking about it.

$ ./prismedia_upload.py --file="Videoblabla Name.mp4" --withThumb
error: Did not found thumbnail
I didn't know for the `.txt` but was aware for the `.jpg`. The problem is that arriving at episode #50 I just don't remember if I already created the thumbnail or not. When uploading on the web interface I see if the thumbnail is ready or not. On CLI I do not have any indication. Especially since `./prismedia_upload.py --file="Videoblabla Name.mp4"` enable me to add the thumbnail without thinking about it. ``` $ ./prismedia_upload.py --file="Videoblabla Name.mp4" --withThumb error: Did not found thumbnail ```
LecygneNoir4年前 にコメント
投稿者
オーナー

Okay I understand.

Indeed in this case displaying a warning is not enough, you want the upload to be stopped, I see why the usecase is useful.

Mmmmh, it could be difficult to choose which option should be strict and which not, and adding another file to configure these options seems too heavy.

Your idea with --withThumb could be a good idea, we may add a bunch of "strict" option to be passed in the cli that stop the upload if something is missing. --withNFO, --withThumb, --withDescription, ...

We may add these option on the cli or in the NFO, the only option "cli only" should be --withNFO. Like that the user may define his strict options in the NFO to avoid a lonnnnng cli.

I'll think about it, thanks for the idea!

If you want to contribute with this idea, feel free ;-)

Okay I understand. Indeed in this case displaying a warning is not enough, you want the upload to be stopped, I see why the usecase is useful. Mmmmh, it could be difficult to choose which option should be strict and which not, and adding another file to configure these options seems too heavy. Your idea with `--withThumb` could be a good idea, we may add a bunch of "strict" option to be passed in the cli that stop the upload if something is missing. `--withNFO`, `--withThumb`, `--withDescription`, ... We may add these option on the cli or in the NFO, the only option "cli only" should be `--withNFO`. Like that the user may define his strict options in the NFO to avoid a lonnnnng cli. I'll think about it, thanks for the idea! If you want to contribute with this idea, feel free ;-)
LecygneNoir がラベル
Todo
を除去 3年前
LecygneNoir がラベル
Work in Progress
を追加 3年前
LecygneNoir3年前 にコメント
投稿者
オーナー

Hello,

I am working on this feature, it should be added in v0.10.0 of Prismedia :-)

Hello, I am working on this feature, it should be added in v0.10.0 of Prismedia :-)
LecygneNoir3年前 にコメント
投稿者
オーナー

Feature added by #25682af83ab54b100f236a9c6ec15699d80520e7

Feature added by #25682af83ab54b100f236a9c6ec15699d80520e7
LecygneNoir が課題をクローズ 3年前
サインインしてこの会話に参加。
マイルストーンなし
担当者なし
2 人の参加者
通知
期日

期日は未設定です。

依存関係

この課題に依存関係はありません。

読み込み中…
まだ内容がありません