#36 Prevent upload when the thumbnail is missing

Closed
opened 4 years ago by Zykino · 7 comments
Zykino commented 4 years ago

I'm thinking about an option like --strict which may be reusable for other components.

I want this option because my thumbnails are not very different from one to the other, just the episode number is changing. So I do a bunch of thumbnails in advance and if I'm not careful, I may upload a video without it.

I'm thinking about an option like `--strict` which may be reusable for other components. I want this option because my thumbnails are not very different from one to the other, just the episode number is changing. So I do a bunch of thumbnails in advance and if I'm not careful, I may upload a video without it.
Poster
Owner

Mmmh, you mean if you specify the --strict option, then it does not upload if thumbnail is missing?

But how can you specify which option are strict for you? I mean, perhaps for another it would be a schedule that is mandatory, or tags, ...

Perhaps an option inside the NFO to specify strict parameters?

Mmmh, you mean if you specify the `--strict` option, then it does not upload if thumbnail is missing? But how can you specify which option are strict for you? I mean, perhaps for another it would be a schedule that is mandatory, or tags, ... Perhaps an option inside the NFO to specify strict parameters?
LecygneNoir added the
More info needed
label 4 years ago
LecygneNoir added the
enhancement
label 4 years ago
Zykino commented 4 years ago
Poster

I thought we choose and hardcode this behavior for pre-selected part. Or the option require that everything is set. But a list in the NFO is the more reasonable when looking this way.

In fact I thought only about thumbnails because they are "external" to the cli: I'm copy pasting the same cmd each time and then I know I need to change 1) the file name 2) the date and 3) the title. The 2 first are triggering errors if I don't change them. (I presetted the date in the past, the name replace the episode number with a "X").

I go to the prismedia's folder, copy the saved cmd from my editor (or your shell history), adapt the cmd. Copy past the saved/memo title.
Then I press [Enter].

I never go in the video's folder where the episodes and thumbnails are (with a similar name so Prismedia find them automatically).

I thought we choose and hardcode this behavior for pre-selected part. Or the option require that everything is set. But a list in the NFO is the more reasonable when looking this way. In fact I thought only about thumbnails because they are "external" to the cli: I'm copy pasting the same cmd each time and then I know I need to change 1) the file name 2) the date and 3) the title. The 2 first are triggering errors if I don't change them. (I presetted the date in the past, the name replace the episode number with a "X"). I go to the prismedia's folder, copy the saved cmd from my editor (or your shell history), adapt the cmd. Copy past the saved/memo title. Then I press `[Enter]`. I never go in the video's folder where the episodes and thumbnails are (with a similar name so Prismedia find them automatically).
LecygneNoir removed the
More info needed
label 4 years ago
LecygneNoir added the
Todo
label 4 years ago
Poster
Owner

Hello,

Regarding your particular problem with thumbnail, do you know that if you name your thumbnail with the same name of your video, prismedia will take it automatically?

For example if your directory contains:

Videoblabla Name.jpg
Videoblabla Name.mp4
Videoblabla Name.txt

Then you only need to passe the .mp4 to prismedia, and it'll use the NFO and the thumbnail automatically!

Eg:

./prismedia_upload.py --file="Videoblabla Name.mp4"

Let me know if it solves your problem :-)

Hello, Regarding your particular problem with thumbnail, do you know that if you name your thumbnail with the same name of your video, prismedia will take it automatically? For example if your directory contains: ``` Videoblabla Name.jpg Videoblabla Name.mp4 Videoblabla Name.txt ``` Then you only need to passe the .mp4 to prismedia, and it'll use the NFO and the thumbnail automatically! Eg: ``` ./prismedia_upload.py --file="Videoblabla Name.mp4" ``` Let me know if it solves your problem :-)
Zykino commented 4 years ago
Poster

I didn't know for the .txt but was aware for the .jpg.

The problem is that arriving at episode #50 I just don't remember if I already created the thumbnail or not.

When uploading on the web interface I see if the thumbnail is ready or not. On CLI I do not have any indication. Especially since ./prismedia_upload.py --file="Videoblabla Name.mp4" enable me to add the thumbnail without thinking about it.

$ ./prismedia_upload.py --file="Videoblabla Name.mp4" --withThumb
error: Did not found thumbnail
I didn't know for the `.txt` but was aware for the `.jpg`. The problem is that arriving at episode #50 I just don't remember if I already created the thumbnail or not. When uploading on the web interface I see if the thumbnail is ready or not. On CLI I do not have any indication. Especially since `./prismedia_upload.py --file="Videoblabla Name.mp4"` enable me to add the thumbnail without thinking about it. ``` $ ./prismedia_upload.py --file="Videoblabla Name.mp4" --withThumb error: Did not found thumbnail ```
Poster
Owner

Okay I understand.

Indeed in this case displaying a warning is not enough, you want the upload to be stopped, I see why the usecase is useful.

Mmmmh, it could be difficult to choose which option should be strict and which not, and adding another file to configure these options seems too heavy.

Your idea with --withThumb could be a good idea, we may add a bunch of "strict" option to be passed in the cli that stop the upload if something is missing. --withNFO, --withThumb, --withDescription, ...

We may add these option on the cli or in the NFO, the only option "cli only" should be --withNFO. Like that the user may define his strict options in the NFO to avoid a lonnnnng cli.

I'll think about it, thanks for the idea!

If you want to contribute with this idea, feel free ;-)

Okay I understand. Indeed in this case displaying a warning is not enough, you want the upload to be stopped, I see why the usecase is useful. Mmmmh, it could be difficult to choose which option should be strict and which not, and adding another file to configure these options seems too heavy. Your idea with `--withThumb` could be a good idea, we may add a bunch of "strict" option to be passed in the cli that stop the upload if something is missing. `--withNFO`, `--withThumb`, `--withDescription`, ... We may add these option on the cli or in the NFO, the only option "cli only" should be `--withNFO`. Like that the user may define his strict options in the NFO to avoid a lonnnnng cli. I'll think about it, thanks for the idea! If you want to contribute with this idea, feel free ;-)
LecygneNoir removed the
Todo
label 3 years ago
LecygneNoir added the
Work in Progress
label 3 years ago
Poster
Owner

Hello,

I am working on this feature, it should be added in v0.10.0 of Prismedia :-)

Hello, I am working on this feature, it should be added in v0.10.0 of Prismedia :-)
Poster
Owner

Feature added by #25682af83ab54b100f236a9c6ec15699d80520e7

Feature added by #25682af83ab54b100f236a9c6ec15699d80520e7
LecygneNoir closed this issue 3 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.