LecygneNoir
/
peertube-helm
1
0
Fork 0
Code Issues 1 Pull Requests 0 Releases 15 Activity
Labels Milestones
New Issue

#7 Make Redis optional

Closed
opened 2 years ago by Ghost · 2 comments
Ghost commented 2 years ago

Hi,

I'm ready to migrate my setup from one k8s cluster to another, and I'd like to use this chart, however, I can't because I need to migrate my data (which for some reason is only in redis...).

I already have a separate redis install (I manage things with argo, so an extra helm install to my taste is fine.

Can you please make redis optional and configurable? https://helm.sh/docs/chart_best_practices/dependencies/ shows how to make a dependency optional, and then there's only the fix for allowing the redis hostname to be specified.

Cheers,

--
Martyn

Hi, I'm ready to migrate my setup from one k8s cluster to another, and I'd like to use this chart, however, I can't because I need to migrate my data (which for some reason is only in redis...). I already have a separate redis install (I manage things with argo, so an extra helm install to my taste is fine. Can you please make redis optional and configurable? https://helm.sh/docs/chart_best_practices/dependencies/ shows how to make a dependency optional, and then there's only the fix for allowing the redis hostname to be specified. Cheers, -- Martyn
LecygneNoir commented 2 years ago
Poster
Owner

Hello!

I didn't know about this conditionnal settings in helm, seems interresting indeed!

In this case, we should add everything to allow a custom configuration in the values.yml to deal with both case.

Anyway, the redis part is very old, historically get from the original chart fork, it should be upgraded...

I'll try to work on it as soon as possible, in the meantime do not hesitate to create a PR if you made some test with your own redis, I would be very interrested!

Thanks,

LecygneNoir

Hello! I didn't know about this conditionnal settings in helm, seems interresting indeed! In this case, we should add everything to allow a custom configuration in the values.yml to deal with both case. Anyway, the redis part is very old, historically get from the original chart fork, it should be upgraded... I'll try to work on it as soon as possible, in the meantime do not hesitate to create a PR if you made some test with your own redis, I would be very interrested! Thanks, LecygneNoir
LecygneNoir commented 3 months ago
Poster
Owner

Closed (at least ^^) with #v1.5.0

Closed (at least ^^) with #v1.5.0
LecygneNoir closed this issue 3 months ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes