#2 Add Nginx proxy as sidecar to expose Peertube

Closed
opened 4 years ago by LecygneNoir · 3 comments
Owner

Hello,

As done in the official docker-compose file (See Peertube #2531), the official nginx configuration shipped with Peertube contains optimisations

While it's not necessary for Peertube to work, it would be interesting to have it in the Kubernetes deployment.

We may use a Nginx sidecar for that, using a configmap and exposing itself the port 9000 instead of Peertube.

We may add an option to enable or not this sidecar.

Objective is the cluster configuration (especially the ingress configured and used by the Ops) do not need changes while this feature is enabled or not.

To achieve that:

  • Use same port 9000, exposing the Nginx or Peertube directly
  • Liveness probes should check Peertube and Nginx correctly
  • Nginx sidecar should wait for Peertube before reporting READY (using some InitContainer?)
Hello, As done in the official docker-compose file (See Peertube [#2531](https://github.com/Chocobozzz/PeerTube/pull/2531)), the official nginx configuration shipped with Peertube contains optimisations While it's not necessary for Peertube to work, it would be interesting to have it in the Kubernetes deployment. We may use a Nginx sidecar for that, using a configmap and exposing itself the port 9000 instead of Peertube. We may add an option to enable or not this sidecar. Objective is the cluster configuration (especially the ingress configured and used by the Ops) do not need changes while this feature is enabled or not. To achieve that: - Use same port 9000, exposing the Nginx or Peertube directly - Liveness probes should check Peertube and Nginx correctly - Nginx sidecar should wait for Peertube before reporting READY (using some InitContainer?)
LecygneNoir added the
enhancement
label 4 years ago
Poster
Owner

Okay helm does not current provides a way to import file from git when installing, so I'll need to integrate directly the file in the helm repo, and check for update regularly.

Ideally I do not think the file will change often

Okay helm does not current provides a way to import file from git when installing, so I'll need to integrate directly the file in the helm repo, and check for update regularly. Ideally I do not think the file will change often
Poster
Owner

Work in progress on PR #4

Work in progress on PR #4
Poster
Owner

Fixed with 1077bdfab9

Fixed with 1077bdfab9fe7970da71d51938bd688b3669d867
LecygneNoir closed this issue 4 years ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.